Conversation
This creates the component for showing the outcome panels. It does not implement the content of each individual panel; it only implements the tabs, panel views, and the general warnings.
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
One question but otherwise all looks good to me.
| <Alert | ||
| type="warning" | ||
| title="Repository limit exceeded" | ||
| message={`The number of requested repositories exceeds the maximum number of repositories supported by multi-repository variant analysis. ${overLimitRepositoryCount} ${overLimitRepositoryCount === 1 ? 'repository was' : 'repositories were'} skipped.`} |
There was a problem hiding this comment.
Maybe I'm just missing them but I can't see this warning or the "access mismatch" warning as part of the designs. Do we need general warning above the tabs, or is it enough just to have the tabs and then there are warnings inside that explain why repos were skipped?
We can leave the implementation of the warnings inside the tabs for when implementing those tabs.
There was a problem hiding this comment.
We talked about this and I was getting confused between the different error states. These general warnings are for the "too many repos" and "public controller repo" cases, which are different from the "no access" and "no db" cases which get their own tabs. So these warnings are all good.
Regarding the specific text for them, let's go with this for now as just a placeholder while everything is private. We'll have a discussion offline about what text to use here and in general throughout the extension.
|
Also need to fix up some merge conflicts from #1541 |
2 participants
This creates the component for showing the outcome panels. It does not implement the content of each individual panel; it only implements the tabs, panel views, and the general warnings.
Checklist
ready-for-doc-reviewlabel there.